[HACKERS] Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements

[Abhijit Menon-Sen]

At 2013-07-26 10:39:00 +0200, karl...@gmail.com wrote:
>
> Hello, as I can see there are more inconsistent places.

Right. This is what I was referring to in my original review. All of the
relevant sites (pre-patch) that currently do:

    if (already exists)
        ereport(ERROR …)

should instead be made to do:

    if (already exists)
    {
        if (ifNotExists)
        {
            ereport(NOTICE …)
            return
        }

        ereport(ERROR …)
    }

or even (very slightly easier to review):

    if (already exists && ifNotExists)
    {
        ereport(ERROR …)
        return
    }

    if (already exists)
        ereport(ERROR …)

I don't care much which of the two is used, so long as it's (a) the same
everywhere, and (b) there's no "if (!ifNot" anywhere.

-- Abhijit


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers