On Tue, Aug 6, 2013 at 12:41 PM, Fujii Masao <masao.fu...@gmail.com> wrote: >> - >> + unlink(PROMOTE_SIGNAL_FILE); >> Wouldn't it make sense to keep the call to stat() to check the file >> status before unlinking it? > > Why do we need to check the existence of the file before removing it > here? Forget what I said, I had in mind that it might have been better to put in silence errors of unlink here. This is not mandatory. -- Michael
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
