Andres Freund wrote: > pg_xlogdump cannot properly be built with pgxs since it needs a > sourcetree around. That already has confused some users... > > How about the attached patch which will tell it's not supported instead > of an ominous build error about files that have no rules?
Hmm, the other option is to ignore USE_PGXS completely and build assuming the source tree is always present. That way, if you build the whole contrib subdir with USE_PGXS=1, you will end up with all modules being built, not stop in the middle with an error. This seems more useful to me. We could just add a comment that USE_PGXS is ignored. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
