On Sat, Sep 14, 2013 at 1:14 PM, Abhijit Menon-Sen <a...@2ndquadrant.com> wrote: > Hi. > > This is a cleaned-up and rebased version of the bitmap index patch from > Gavin Sherry, later revised by Gianni Ciolli and Gabriele Bartolini, and > others including Daniel Bausch. >
Hi Abhijit, Please, in the next update consider this messages i'm getting when compiling with your patch. """ bitmapxlog.c: In function ‘bitmap_xlog_cleanup’: bitmapxlog.c:658:32: warning: ‘reln’ may be used uninitialized in this function [-Wuninitialized] selfuncs.c: In function ‘bmcostestimate’: selfuncs.c:7327:13: warning: unused variable ‘indexCorrelation’ [-Wunused-variable] selfuncs.c:7326:15: warning: unused variable ‘indexSelectivity’ [-Wunused-variable] selfuncs.c:7325:11: warning: unused variable ‘indexTotalCost’ [-Wunused-variable] selfuncs.c:7324:11: warning: unused variable ‘indexStartupCost’ [-Wunused-variable] """ Also, there are 2 regression tests failing (attached regression.diffs) And this error, when trying to generate docs """ openjade:bitmap.sgml:123:85:X: reference to non-existent ID "SQL-CREATEINDEX-TITLE" """ And finally, i was excercising the feature in some ways and got a crash when creating an index concurrently (attached index_failure.txt), it wasn't just a crash i couldn't start up the server again after it -- Jaime Casanova www.2ndQuadrant.com Professional PostgreSQL: Soporte 24x7 y capacitación Phone: +593 4 5107566 Cell: +593 987171157
postgres=# create index concurrently idx_t1_i on t1 using bitmap (i);
TRAP: FailedAssertion("!(GetTopTransactionIdIfAny() == ((TransactionId) 0))",
File: "index.c", Line: 3011)
La conexión al servidor se ha perdido. Intentando reiniciar: LOG: server
process (PID 20955) was terminated by signal 6: Aborted
DETAIL: Failed process was running: create index concurrently idx_t1_i on t1
using bitmap (i);
LOG: terminating any other active server processes
WARNING: terminating connection because of crash of another server process
DETAIL: The postmaster has commanded this server process to roll back the
current transaction and exit, because another server process exited abnormally
and possibly corrupted shared memory.
HINT: In a moment you should be able to reconnect to the database and repeat
your command.
FATAL: the database system is in recovery mode
falló.
Duración: 239,212 ms
!> LOG: all server processes terminated; reinitializing
LOG: database system was interrupted; last known up at 2013-09-15 23:21:15 ECT
LOG: database system was not properly shut down; automatic recovery in progress
LOG: redo starts at 0/AA9C4E8
PANIC: _bitmap_xlog_insert_last_bitmapwords: VMI block not found: 5
CONTEXT: xlog redo insert words in a not-last bitmap page: rel 1663/12937/70025
LOG: startup process (PID 24399) was terminated by signal 6: Aborted
LOG: aborting startup due to startup process failure
regression.diffs
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
