On 17/10/13 17:23, Alvaro Herrera wrote:
Oskari Saarenmaa wrote:@@ -1241,8 +1241,8 @@ hstore_to_json_loose(PG_FUNCTION_ARGS) if (count == 0) { - out = palloc(1); - *out = '\0'; + out = palloc(3); + memcpy(out, "{}", 3); PG_RETURN_TEXT_P(cstring_to_text(out)); }Can't you just PG_RETURN_TEXT_P(cstring_to_text("{}")) ?
I'm not too familiar with PG internals and just modified this to work like it did before, but it looks like the extra allocation is indeed unnecessary.
I can post a new patch to make this use cstring_to_text_with_len("{}", 2) (to avoid an unnecessary strlen call) or you can just make the change and push the modified version.
Thanks, Oskari -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
