Andres Freund escribió: > On 2013-10-30 10:52:05 -0300, Alvaro Herrera wrote: > > Robert Haas escribió: > > > On Wed, Oct 30, 2013 at 4:51 AM, David Rowley <dgrowle...@gmail.com> > > > wrote: > > > > I've attached a re-based version of this. > > > > > > I don't see any compelling reason not to commit this. Does anyone > > > wish to object? > > > > I think a blanket substitution of places that currently have %s might > > cause bugs, particularly if the string is user-supplied. It might be > > right for many cases, but did you/someone review each such callsite? > > > > No objection to the other half, that substitute calls that don't have > > %s. > > appendStringInfoString() doesn't expand format strings, so I am not sure > what you're worried about?
Um. Blame my lack of decent breakfast this morning. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
