Amit Kapila <amit.kapil...@gmail.com> writes:
> On Fri, Nov 1, 2013 at 9:50 AM, Tom Lane <t...@sss.pgh.pa.us> wrote:
>> I think this is adding fragility for absolutely no meaningful savings.
>> The existing code does not depend on the assumption that the array
>> is filled consecutively and no entries are closed early.
> As I could see, it appears to me that code in ServerLoop and
> initMasks is already dependent on it, if any socket is closed out of
> order, it can break the logic in these API's. Do me and Gurjeet are
> missing some point here?
It's not hard to foresee that we might have to fix those assumptions
someday. If we were buying a lot by adding a similar assumption here,
it might be worth doing even in the face of having to revert it later.
But we're not buying much. A few instructions during postmaster shutdown
is entirely negligible.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
