On Tue, 2013-11-05 at 18:29 +0200, Oskari Saarenmaa wrote: > This can be used to tag custom built packages with an extra version string > such as the git describe id or distribution package release version.
I think this is a reasonable feature, and the implementation is OK, but I don't see why the format of the extra version information needs to be exactly PG_VERSION="$PACKAGE_VERSION ($withval)" I'd imagine, for example, that someone will want to do -something or +something. So I'd just make this PG_VERSION="$PACKAGE_VERSION$withval" Comments? > +# Allow adding a custom string to PG_VERSION > +PGAC_ARG_REQ(with, extra-version, [NAME], [extra version information], > +[PG_VERSION="$PACKAGE_VERSION ($withval)"], [PG_VERSION="$PACKAGE_VERSION"]) This could be indented better. It was a bit confusing at first. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers