On Fri, Nov 22, 2013 at 11:27:45AM -0500, Tom Lane wrote: > I think this is probably nonsense. I spent ten years maintaining Postgres > for Red Hat, and I never saw any such failure on s390 in their packages. > If -fpic weren't good enough for shared libraries on s390, how'd any of > those builds get through their regression tests?
You've got a point here. > It may well be that *mixing* -fpic and -fPIC is a bad idea, but I'd say > that points to an error in something XC is doing, because the core > Postgres build doesn't use -fPIC anywhere for Linux/s390, AFAICS. I actually only compared to the Debian build which *does* have -fPIC and indeed it seems it adds -fPIC unconditionally. But then the PostgreSQL package works flawlessly which obviously points to XC for the problem. I give you that. > Furthermore, if we change that convention now, we're going to increase > the risk of such mixing failures for other people. Sure, but if this a bug we should. I'm not saying it is, I simply don't know. The thread is starting with my email here http://lists.debian.org/debian-s390/2013/10/msg00008.html and the reply said: It uses -fpic instead of -fPIC. No, I'm not shortening that email reply here. :) Checking the Debian logs it appears that all calls use *both* which seems to do the right thing. And yes, it appears there is a change in XC that makes it break. But still, I would think there has to be a correct set of options. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
