On 16/09/13 16:20, Satoshi Nagayasu wrote: > Thanks for checking. Fixed to eliminate SnapshotNow.
Looking forward to get a new patch, incorporating the comments, that are already given in the following mails: 1. Jaime Casanova: "The name pgstattuple2, doesn't convince me... maybe you can use pgstattuple() if you use a second argument (percentage of the sample) to overload the function". (http://www.postgresql.org/message-id/5265ad16.3090...@catalyst.net.nz) The comment related to having an argument, to mention the sampling number, is also given by Greg Smith: "There should be an input parameter to the function for how much sampling to do" (http://www.postgresql.org/message-id/51ee62d4.7020...@2ndquadrant.com) 2. Yourself: "I think it could be improved by sorting sample block numbers before physical block reads in order to eliminate random access on the disk." (http://www.postgresql.org/message-id/525779c5.2020...@uptime.jp) for which, Mark Kirkwood , has given a rough patch. Regards, Firoz EV
