On Sat, Dec 28, 2013 at 10:36:19PM -0500, Peter Eisentraut wrote:
> While playing around with the pginclude tools, I noticed that pgcrypto
> header files are failing to include some header files whose symbols they
> use. This change would fix it:
> diff --git a/contrib/pgcrypto/pgp.h b/contrib/pgcrypto/pgp.h
> index 3022abf..f856e07 100644
> --- a/contrib/pgcrypto/pgp.h
> +++ b/contrib/pgcrypto/pgp.h
> @@ -29,6 +29,9 @@
> * contrib/pgcrypto/pgp.h
> +#include "mbuf.h"
> +#include "px.h"
> enum PGP_S2K_TYPE
> PGP_S2K_SIMPLE = 0,
> Does that look reasonable?
It's a style question - currently pgp.h expects other headers to be
included in .c files. Including them in pgp.h might be better style,
but then please sync .c files with it too.
Sent via pgsql-hackers mailing list (firstname.lastname@example.org)
To make changes to your subscription: