On Mon, Jan 13, 2014 at 4:30 PM, Oskari Saarenmaa <o...@ohmu.fi> wrote:
> Hi, > > > On 13/01/14 10:26, Jeevan Chalke wrote: > >> 1. Documentation is missing and thus becomes difficult to understand what >> exactly you are trying to do. Or in other words, user will be uncertain >> about using it more efficiently. >> > > I figured I'd write documentation for this if it looks like a useful > feature which would be accepted for 9.4, but I guess it would've helped to > have a bit better description of this for the initial submission as well. > > > 2. Some more comments required. At each new function and specifically at >> get_sqlstate_error_level(). >> > > Just after I submitted the patch I noticed that I had a placeholder for > comment about that function but never wrote the actual comment, sorry about > that. > > > 3. Please add test-case if possible. >> > > Sure. > > > 4. Some code part does not comply with PostgreSQL indentation style. (Can >> be >> ignored as it will pass through pg_indent, but better fix it). >> > > I'll try to fix this for v2. > > > 5. You have used ""XX000:warning," string to get maximum possible length >> of >> the valid sqlstate:level identifier. It's perfect, but small explanation >> about that will be good there. Also in future if we have any other error >> level >> which exceeds this, we need changes here too. Right ? >> > > Good point, I'll address this in v2. > > > I will look into this further. But please have your attention on above >> points. >> > > Thanks for the review! > Since you are taking care of most of the points above. I will wait for v2 patch. Till then marking "Waiting on Author". Thanks > > / Oskari > > > On Fri, Jan 10, 2014 at 12:56 AM, Oskari Saarenmaa <o...@ohmu.fi> >> wrote: >> > Allow the default log_min_error_statement to be overridden per >> > sqlstate to make it possible to filter out some error types while >> > maintaining a low log_min_error_statement or enable logging for some >> > error types when the default is to not log anything. >> > >> > I've tried to do something like this using rsyslog filters, but >> > that's pretty awkward and doesn't work at all when the statement is >> > split to multiple syslog messages. >> > >> > https://github.com/saaros/postgres/compare/log-by-sqlstate >> > > -- Jeevan B Chalke Principal Software Engineer, Product Development EnterpriseDB Corporation The Enterprise PostgreSQL Company Phone: +91 20 30589500 Website: www.enterprisedb.com EnterpriseDB Blog: http://blogs.enterprisedb.com/ Follow us on Twitter: http://www.twitter.com/enterprisedb This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.
