On Sun, Dec 8, 2013 at 10:27 AM, Marko Kreen <mark...@gmail.com> wrote:
> On Fri, Dec 06, 2013 at 02:53:27PM +0100, Dr. Andreas Kunert wrote: > > >>Anything else missing? > > > > > >Functionally it's fine now, but I see few style problems: > > > > > >- "if (port->ssl > 0)" is wrong, ->ssl is pointer. So use just > > > "if (port->ssl)". > > >- Deeper indentation would look nicer with braces. > > >- There are some duplicated message, could you restructure it so that > > > each message exists only once. > > > > New version is attached. I could add braces before and after the > > ereport()-calls too, but then I need two more #ifdefs to catch the > > closing braces. > > Thank you. Looks good now. I added it to next commitfest: > > https://commitfest.postgresql.org/action/patch_view?id=1324 > > Applied, thanks! -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
