On Fri, Jan 24, 2014 at 9:00 PM, MauMau <maumau...@gmail.com> wrote: > From: "Fujii Masao" <masao.fu...@gmail.com> > >> I think that 77035fa8a92d8c39f4c689e54f46813f203f09a8 fixed this problem. >> Please check that. > > > I looked through your patch. I'm fine with the PQhostaddr(). I didn't > notice the problem when hostaddr was passed to psql on Windows. > > OTOH, regarding PQhost(), I think we had better take my patch. > connectOptions2() computes and set derived values to PGconn, so that > PGconn's members have values which are actually used for connection. To > follow that rule, PGconn->pghost may as well have "localhost" on machines > without UNIX domain sockets.
Advertising
I'm not sure if we should follow that rule. As far as I read the libpq code, at least connectFailureMessage() and connectDBStart() do the same things as PQhost() does now. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
