On Thu, Jan 30, 2014 at 11:44:31PM -0500, Tom Lane wrote: > Bruce Momjian <br...@momjian.us> writes: > > OK, seven hours later, I have fixed pg_bsd_indent to no longer insert > > blank lines above #elif/#else/#endif, and therefore removed the special > > case code from pgindent. > > > You will need to download version 1.3 of pg_bsd_indent for this to work, > > and pgindent will complain if it doesn't find the right pg_bsd_indent > > version. > > Cool. > > > Do we need to go an clean up any places where pgindent has suppressed > > blank lines above #elif/#else/#endif in the past? > > Not sure it's worth making a massive change for this, but I appreciate the > fact that pgindent won't mess up such code in the future.
Yes, it is a shame pgindent has removed many proper empty lines in the past and there is no way to re-add them without causing backpatching problems. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers