On Wed, Feb 26, 2014 at 1:23 PM, Andrew Dunstan <and...@dunslane.net> wrote:
>>> + if (va->string.len == vb->string.len)
>>> + {
>>> + res = memcmp(va->string.val, vb->string.val,
>>> va->string.len);
>>> + if (res == 0 && arg)
>>> + *(bool *) arg = true;
>>
>> Should be NULL, not 0.
>
>
> No, the compiler doesn't like that for int values.
I'm confused. I just pulled from feodor/jsonb_and_hstore, and I do see
a compiler warning (because the code reads "res == NULL", unlike
above). It appears to have been that way in Git since last year. So,
maybe Andres meant that it *should* look like this?
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
