Re: [HACKERS] trailing comment ghost-timing

[Bruce Momjian]

On Mon, Mar 31, 2014 at 02:06:28PM -0400, Bruce Momjian wrote:
> Where are we on this?  It seem odd that psql sends /* */ comments to the
> server, but not "--" comments.  Should this be documented or changed?
> 
> I am confused why changing the behavior would affect the regression test
> output as -- and /* */ comments already appear, and it was stated that
> "--" comments are already not sent to the server.
> 
> Everyone agreed that suppressing \timing output for a PGRES_EMPTY_QUERY
> return result was not a good idea.

I have applied the attached document patch to document that '--'
comments are not passed to the server, while C-style block comments are.
We can call this a feature.  ;-)

-- 
  Bruce Momjian  <br...@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +

diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml
new file mode 100644
index 5dce06a..85899d7
*** a/doc/src/sgml/ref/psql-ref.sgml
--- b/doc/src/sgml/ref/psql-ref.sgml
*************** testdb=&gt;
*** 679,684 ****
--- 679,690 ----
      <xref linkend="SQL-LISTEN"> and
      <xref linkend="SQL-NOTIFY">.
      </para>
+ 
+     <para>
+     While C-style block comments are passed to the server for
+     processing and removal, SQL-standard comments are removed by
+     <application>psql</application>.
+     </para>
    </refsect2>
  
    <refsect2 id="APP-PSQL-meta-commands">

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers