Hi, We really should fix this one of these days.
On 2014-03-26 18:45:54 -0700, Peter Geoghegan wrote: > Attached patch silences the "Invalid read of size n" complaints of > Valgrind. I agree with your general thoughts around backpatching. Note > that the patch addresses a distinct complaint from Kevin's, as > Valgrind doesn't take issue with the invalid reads past the end of > spgxlogPickSplit variables on the stack. I don't think that's entirely sufficient. The local spgxlogPickSplit xlrec;/spgxlogMoveLeafs xlrec; variables are also inserted while MAXLIGNing their size. That's slightly harder to fix :(. I don't have a better idea than also allocating them dynamically :( Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
