On Tue, May 6, 2014 at 09:22:20AM -0400, Noah Misch wrote: > On Mon, May 05, 2014 at 08:29:56PM -0400, Bruce Momjian wrote: > > On Tue, Apr 22, 2014 at 03:19:15PM -0400, Bruce Momjian wrote: > > > As is often the case with pg_dump, the problems you saw are a small part > > > of a larger set of problems in that code --- there is general ignoring of > > > read and write errors. > > > > > > I have developed a comprehensive patch that addresses all the issues I > > > could find. The use of function pointers and the calling of functions > > > directly and through function pointers makes the fix quite complex. I > > > ended up placing checks at the lowest level and removing checks at > > > higher layers where they were sporadically placed. > > > > > > Patch attached. I have tested dump/restore of all four dump output > > > formats with the 9.3 regression database and all tests passed. I > > > believe this patch is too complex to backpatch, and I don't know how it > > > could be fixed more simply. > > > > Patch applied. Thanks for the report. > > This broke automatic detection of tar-format dumps: > > $ pg_dump -Ft -f tardump > $ pg_restore tardump > pg_restore: [archiver] could not read from input file: Success > $ pg_restore -Ft tardump | wc -c > 736
OK, thanks for the report. Fixed. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
