Hi,

examine_attribute() function accept Relation type argument, and extract 
attribute from it.


For more granularity, I think passing Form_pg_attribute to examine_attribute() 
function  rather than passing Relation will be more relevant & makes it simple 
to understand.

Thinking to change examine_attribute as,

- examine_attribute(Relation onerel, int attnum, Node *index_expr)
+examine_attribute(Form_pg_attribute attr, Node *index_expr)
 

I think there wont any loss or gain except little optimization of function call 
stack space. 

Thoughts? comments?

Please have look attached patch.

Regards,

Amul Sul

Attachment: 0001-examine_attribute-function-s-arguments-changed.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to