On 13 June 2014 13:01, Abhijit Menon-Sen Wrote > > I've changed this to use %zu at Álvaro's suggestion. I'll post an > updated patch after I've finished some (unrelated) refactoring.
I have started reviewing the patch.. 1. Patch applied to git head cleanly. 2. Compiled in Linux -- Some warnings same as mentioned by furuyao 3. Some compilation error in windows .\contrib\pg_xlogdump\pg_xlogdump.c(1002) : error C2065: 'optional_argument' : undeclared identifier .\contrib\pg_xlogdump\pg_xlogdump.c(1002) : error C2099: initializer is not a constant optional_argument should be added to getopt_long.h file for windows. Please fix these issues and send the updated patch.. I will continue reviewing the patch.. Regards, Dilip -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers