On 6 July 2014 03:20, Tom Lane <t...@sss.pgh.pa.us> wrote:

> David Rowley <dgrowle...@gmail.com> writes:
> > Attached is a delta patch between version 1.2 and 1.3, and also a
> > completely updated patch.
> Just to note that I've started looking at this, and I've detected a rather
> significant omission: there's no check that the join operator has anything
> to do with the subquery's grouping operator.  I think we need to verify
> that they are members of the same opclass, as
> relation_has_unique_index_for does.
hmm, good point. If I understand this correctly we can just ensure that the
same operator is used for both the grouping and the join condition.

I've attached a small delta patch which fixes this, and also attached the
full updated patch.


David Rowley

Attachment: subquery_leftjoin_removal_v1.4.patch
Description: Binary data

Attachment: subquery_leftjoin_removal_v1.4_delta.patch
Description: Binary data

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to