Re: Bruce Momjian 2014-07-08 <20140708202114.gd9...@momjian.us> > > > > I believe pg_upgrade itself still needs a fix. While it's not a > > > > security problem to put the socket in $CWD while upgrading (it is > > > > using -c unix_socket_permissions=0700), this behavior is pretty > > > > unexpected, and does fail if your $CWD is > 107 bytes. > > > > > > > > In f545d233ebce6971b6f9847680e48b679e707d22 Peter fixed the pg_ctl > > > > perl tests to avoid that problem, so imho it would make even more > > > > sense to fix pg_upgrade which could also fail in production. > > > > > > +1. Does writing that patch interest you? > > > > I'll give it a try once I've finished this CF review. > > OK. Let me know if you need help.
Here's the patch. Proposed commit message: Create pg_upgrade sockets in temp directories pg_upgrade used to use the current directory for UNIX sockets to access the old/new cluster. This fails when the current path is > 107 bytes. Fix by reusing the tempdir code from pg_regress introduced in be76a6d39e2832d4b88c0e1cc381aa44a7f86881. For cleanup, we need to remember up to two directories. Christoph -- c...@df7cb.de | http://www.df7cb.de/ -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers