On Mon, Aug 18, 2014 at 4:01 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Mon, Aug 18, 2014 at 3:48 PM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Mon, Aug 18, 2014 at 2:38 PM, Michael Paquier >> <michael.paqu...@gmail.com> wrote: >>> - IDENTIFY_SYSTEM checks were incorrect (even in HEAD). The following >>> check was done but in 9.4 this command returns 4 fields: >>> (PQntuples(res) != 1 || PQnfields(res) < 3) >>> That's not directly related to this patch, but making some corrections >>> is not going to hurt.. >> >> Good catch! I found that libpqwalreceiver.c, etc have the same problem. >> It's better to fix this separately. Patch attached. > Patch looks good to me.
Okay, applied! > Once you push that I'll rebase the stuff on > this thread once again, that's going to conflict for sure. And now > looking at your patch there is additional refactoring possible with > IDENTIFY_SYSTEM and pg_basebackup as well... Yep, that's possible. But since the patch needs to be back-patch to 9.4, I didn't do the refactoring. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers