On 07/07/2014 11:46 AM, Abhijit Menon-Sen wrote:
At 2014-07-07 14:02:15 +0530, amit.khande...@enterprisedb.com wrote:


Other than some minor comments as mentioned below, I don't have any
more issues, it looks all good.

Thank you. (Updated patch attached.)

I don't think the new GetBufferWithoutRelcache function is in line with the existing ReadBuffer API. I think it would be better to add a new ReadBufferMode - RBM_CACHE_ONLY? - that only returns the buffer if it's already in cache, and InvalidBuffer otherwise.

- Heikki



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to