(2014/08/21 13:21), Ashutosh Bapat wrote:
On Wed, Aug 20, 2014 at 3:25 PM, Etsuro Fujita
<fujita.ets...@lab.ntt.co.jp <mailto:fujita.ets...@lab.ntt.co.jp>> wrote:
I am sorry that I mistook your name's spelling.
(2014/08/14 22:30), Ashutosh Bapat wrote:
On Thu, Aug 14, 2014 at 10:05 AM, Etsuro Fujita
(2014/08/08 18:51), Etsuro Fujita wrote:
>>> (2014/06/30 22:48), Tom Lane wrote:
>>>> I wonder whether it isn't time to change that. It
>>>> originally only because calculating the values
would've been a
>>>> cycles at the time. But this is at least the third place
where it'd be
>>>> useful to have attr_needed for child rels.
There was a problem with the previous patch, which will be
below. Attached is the updated version of the patch
Here are some more comments
attr_needed also has the attributes used in the restriction
seen in distribute_qual_to_rels(), so, it looks unnecessary to call
pull_varattnos() on the clauses in baserestrictinfo in functions
IIUC, I think it's *necessary* to do that in those functions since
the attributes used in the restriction clauses in baserestrictinfo
are not added to attr_needed due the following code in
That's right. Thanks for pointing that out.
Although in case of RTE_RELATION, the 0th entry in attr_needed
corresponds to FirstLowInvalidHeapAttributeNu__mber + 1, it's
to use it is RelOptInfo::min_attr, in case get_relation_info()
change assumption or somewhere down the line some other part of code
wants to change attr_needed information. It may be unlikely, that it
would change, but it will be better to stick to comments in
443 AttrNumber min_attr; /* smallest attrno of rel
444 AttrNumber max_attr; /* largest attrno of rel */
445 Relids *attr_needed; /* array indexed [min_attr ..
Good point! Attached is the revised version of the patch.
If the patch is not in the commit-fest, can you please add it there?
I've already done that:
From my side, the review is done, it should be marked "ready for
committer", unless somebody else wants to review.
Sent via pgsql-hackers mailing list (email@example.com)
To make changes to your subscription: