On Thu, May 1, 2014 at 12:09:34PM -0400, Bruce Momjian wrote:
> On Thu, May 1, 2014 at 12:33:51PM +1200, Gavin Flower wrote:
> > On 01/05/14 12:04, Bruce Momjian wrote:
> > >On Thu, May 1, 2014 at 08:27:49AM +1200, Gavin Flower wrote:
> > >>On 01/05/14 02:51, Bruce Momjian wrote:
> > >>>The table of contents for pg_restore -l shows the time the archive was
> > >>>made as local time (it uses ctime()):
> > >>>
> > >>> ; Archive created at Wed Apr 30 10:03:28 2014
> > >>>
> > >>>Is this clear enough that it is local time? Should we display this
> > >>>better, perhaps with a time zone designation?
> > >>>
> > >>I think it would be good to include the time zone, as we are all
> > >>very international these days - and in Australia, adjacent states
> > >>have different dates for the summer time transition!
> > >>
> > >>Personally, I would like to see the date in the format 2014-04-30,
> > >>but having the day of the week is good.
> > >>
> > >>Milliseconds might be useful, if you want to check logs files.
> > >OK, I will work on it for 9.5. Thanks.
> > >
> > So the it would then read something like:
> >
> > ; Archive created at Wed 2014-04-30 10:03:28.042 NZST
> >
> > (but with the correct appropriate time zone designation)?
>
> I think we would use a numeric offset.
I ended up going with the string-based timezone as I was worried that
the sign of the timezone could easily confuse people because the SQL
timezone offset sign is often different from the OS timezone. The new
output is:
;
; Archive created at Wed Sep 3 16:12:21 2014 EST <--
; dbname: test
; TOC Entries: 8
; Compression: -1
; Dump Version: 1.12-0
; Format: CUSTOM
; Integer: 4 bytes
; Offset: 8 bytes
; Dumped from database version: 9.5devel
; Dumped by pg_dump version: 9.5devel
Patch attached.
--
Bruce Momjian <br...@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
diff --git a/src/bin/pg_dump/pg_backup_archiver.c b/src/bin/pg_dump/pg_backup_archiver.c
new file mode 100644
index 0018720..4296c11
*** a/src/bin/pg_dump/pg_backup_archiver.c
--- b/src/bin/pg_dump/pg_backup_archiver.c
*************** PrintTOCSummary(Archive *AHX, RestoreOpt
*** 969,975 ****
if (ropt->filename)
SetOutput(AH, ropt->filename, 0 /* no compression */ );
! ahprintf(AH, ";\n; Archive created at %s", ctime(&AH->createDate));
ahprintf(AH, "; dbname: %s\n; TOC Entries: %d\n; Compression: %d\n",
AH->archdbname, AH->tocCount, AH->compression);
--- 969,975 ----
if (ropt->filename)
SetOutput(AH, ropt->filename, 0 /* no compression */ );
! ahprintf(AH, ";\n; Archive created at %.24s %s\n", ctime(&AH->createDate), *tzname);
ahprintf(AH, "; dbname: %s\n; TOC Entries: %d\n; Compression: %d\n",
AH->archdbname, AH->tocCount, AH->compression);
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
