On 20 August 2014 19:49, Amit Kapila Wrote


> There are some comments I would like to share with you
>
>
>
> 1.      Rebase the patch to current GIT head.
>Done.

>> +                      initStringInfo(&symlinkfbuf);
>>
>>             I think declaration and initialization of symlinkfbuf string can 
>> be moved under #ifdef WIN32 compile time macro,
>>
>> for other platform it’s simply allocated and freed which can be avoided.
>Agreed, I have changed the patch as per your suggestion.

I have done the testing and behavior is as per expectation,
Do we need to do some document change? I mean is this limitation on windows is 
mentioned anywhere ?
If no change then i will move the patch to “Ready For Committer”.

Thanks & Regards,
Dilip

Reply via email to