On 2014-09-19 12:38:39 -0400, Stephen Frost wrote: > I would not (nor do I feel that I did..) have committed it over a > specific request to not do so from another committer. I had been hoping > that there would be another review coming from somewhere, but there is > always a trade-off between waiting longer to get a review ahead of a > commit and having it committed and then available more easily for others > to work with, review, and generally moving forward.
Sure, there is such a tradeoff. But others have to wait months to get enough review. The first revision of the patch in the form you committed was sent 2014-08-19, the first marked *ready for review* (not my words) is from 2014-08-30. 19 days really isn't very far along the tradeoff from waiting for a review to uselessly waiting. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers