On 2014-09-19 19:34:08 -0300, Alvaro Herrera wrote: > Andres Freund wrote: > > Hi, > > > > On 2014-09-19 15:39:37 +0530, Abhijit Menon-Sen wrote: > > > I've attached the revised patch, split up differently: > > > > > > 1. Introduce rm_identify, change rm_desc, glue the two together in > > > xlog.c > > > 2. Introduce pg_xlogdump --stats[=record]. > > > > I've pushed these after some fixing up. > > Hm, did you keep the static thingy you mentioned upthread (append_init > which is duped unless I read wrong)?
Yes, I did. > There's quite some angst due to pg_dump's fmtId() -- I don't think we > should be introducing more such things ... I don't think these two are comparable. I don't really see many more users of this springing up and printing the identity of two different records in the same printf doesn't seem likely either. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
