On 2014-09-29 14:44:42 -0400, Tom Lane wrote: > Robert Haas <robertmh...@gmail.com> writes: > > The items I see are: > > > - Remove xloginsert_slots/xloginsert_locks GUC - Not yet!! > > > The text seems to indicate that there's some disagreement on this > > point. I don't have a strong opinion on whether or not to keep the > > GUC, but if we're going to remove it it should probably happen before > > beta3. It's going to be impossible to remove once we've released with > > it, I suspect. > > The lack of any documentation for the GUC (neither in config.sgml or > postgresql.conf.sample) suggests very very strongly that it was not > meant to be shipped.
That's definitely the case. > If we don't remove it I will certainly insist that it be documented > adequately. Definitely. > Personally I think a hardwired #define should be plenty. What's the > argument that users will need to tune this at runtime? That right now it can make quite noticeable differences in scalability. And we have not much data to justify 8 as the default. And that's surely not going to change if we require recompiles. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
