Hi,
we have seen repeatedly that users can be confused about why PostgreSQL
is not shutting down even though they requested it. Usually, this is
because `log_checkpoints' is not enabled and the final checkpoint is
being written, delaying shutdown. As no message besides "shutting down"
is written to the server log in this case, we even had users believing
the server was hanging and pondering killing it manually.
In order to alert those users that a checkpoint is being written, I
propose to add a log message "waiting for checkpoint ..." on shutdown,
even if log_checkpoints is disabled, as this particular checkpoint might
be important information.
I've attached a trivial patch for this, should it be added to the next
commitfest?
Cheers,
Michael
--
Michael Banck
Projektleiter / Berater
Tel.: +49 (2161) 4643-171
Fax: +49 (2161) 4643-100
Email: michael.ba...@credativ.de
credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Hohenzollernstr. 133, 41061 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 5a4dbb9..78483ca 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -8085,10 +8085,14 @@ CreateCheckPoint(int flags)
/*
* If enabled, log checkpoint start. We postpone this until now so as not
- * to log anything if we decided to skip the checkpoint.
+ * to log anything if we decided to skip the checkpoint. If we are during
+ * shutdown and checkpoints are not being logged, add a log message that a
+ * checkpoint is to be written and shutdown is potentially delayed.
*/
if (log_checkpoints)
LogCheckpointStart(flags, false);
+ else if (flags & CHECKPOINT_IS_SHUTDOWN)
+ ereport(LOG, (errmsg("waiting for checkpoint ...")));
TRACE_POSTGRESQL_CHECKPOINT_START(flags);
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
