On Fri, Oct 3, 2014 at 7:25 PM, Fabrízio de Royes Mello <fabriziome...@gmail.com> wrote: > I agree with your grammar change.
Cool. > The version 5 (attached) contains all discussed until now. From documentation: CREATE INDEX ... [ IF NOT EXISTS name | name ] ON ... Maybe I'm just slow, but it took me a few minutes to understand what this means. :) I would add a human-language explanation to IF NOT EXISTS description: Index name is required when IF NOT EXISTS is specified ---- You have resurrected this bit again, which now conflicts with git master... - write_msg(NULL, "reading row-security enabled for table \"%s\"", + write_msg(NULL, "reading row-security enabled for table \"%s\"\n", ---- n->concurrent = $4; + n->if_not_exists = false; n->idxname = $5; Minor stylistic thing: now that this is a constant, I would move it to the end together with other constant assignments, and follow the struct's field ordering (in both code paths): n->isconstraint = false; n->deferrable = false; n->initdeferred = false; n->if_not_exists = false; Regards, Marti -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
