Sawada Masahiko wrote: > Thank you for reviewing. > I agree 2) - 5). > Attached patch is latest version patch I modified above. > Also, I noticed I had forgotten to add the patch regarding document of > reindexdb.
Please don't use pg_catalog in the regression test. That way we will need to update the expected file whenever a new catalog is added, which seems pointless. Maybe create a schema with a couple of tables specifically for this, instead. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
