On 2014-11-01 13:45:44 +0900, Michael Paquier wrote: > 14) I'd put the two checks in the reverse order: > + Assert(xid != InvalidTransactionId); > + > + if (!commit_ts_enabled) > + return;
Please don't. The order is correct right now. Why you ask? This way the correctness of the callsites is checked even when committs is disabled. Which it'll likely be on the majority of developer setups. And what's the upsite of changing the order? There's no difference in the generated code in production builds and the overhead in assert enabled ones is neglegible. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
