On Mon, Nov 10, 2014 at 1:48 PM, Peter Geoghegan <p...@heroku.com> wrote:
> On Fri, Nov 7, 2014 at 12:57 PM, Robert Haas <robertmh...@gmail.com> > wrote: > > Based on this review from a month ago, I'm going to mark this Waiting > > on Author. If nobody updates the patch in a few days, I'll mark it > > Returned with Feedback. Thanks. > > Attached revision fixes the compiler warning that Heikki complained > about. I maintain SQL-callable stub functions from within contrib, > rather than follow Michael's approach. In other words, very little has > changed from my revision from July last [1]. > FWIW, I still find this bit of code that this patch adds in varlena.c ugly: +#include "levenshtein.c" +#define LEVENSHTEIN_LESS_EQUAL +#include "levenshtein.c" +#undef LEVENSHTEIN_LESS_EQUAL -- Michael
