On 11/19/2014 04:54 PM, Alvaro Herrera wrote:
Also I'm surprised that BRIN did not turn up here. At least the "page evacuation protocol" to obtain a new revmap page is not exercised by the current tests. I suppose it's because all WAL records are covered by other activity, and page evacuation does not emit a specialized WAL record. If we have the "big" test for this, maybe we can enlarge the table for the brin index too to ensure we cover this.
Yeah, all of BRIN's redo functions are fully covered by current regression tests. Well done :-).
The evacuation code indeed isn't covered. That would be pretty easy to fix; just make a table that has a brin index on it large enough.
- Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
