On Thu, Nov 20, 2014 at 8:05 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > I'm not particularly convinced that the "f1" -> "f2" example is a useful > behavior, and I'm downright horrified by the "qty" -> "quantity" case. > If the hint mechanism thinks the latter two are close enough together > to suggest, it's going to be spewing a whole lot of utterly ridiculous > suggestions. I'm going to be annoyed way more times than I'm going to > be helped.
I happen to think that that isn't the case, because the number of possible suggestions is fairly low anyway, and people don't tend to make those kind of errors. Robert's examples of "ridiculous" suggestions of "quantity" based on three letter strings other than "qty" (e.g. "tit") were rather contrived. In fact, most 3 letter strings will not offer a suggestion. 3 or more Equidistant would-be matches tend to offer a lot of additional protection against bad suggestions for these terse strings. > The big picture is that this is more or less our first venture into > heuristic suggestions. I think we should start slow with a very > conservative set of heuristics. If it's a success maybe we can get more > aggressive over time --- but if we go over the top here, the entire > concept will be discredited in this community for the next ten years. I certainly see your point here. It's not as if we have an *evolved* understanding of the usability issues. Besides, as Robert pointed out, most of the value of this patch is added by simple cases, like a failure to pluralize or not pluralize, or the omission of an underscore. I still think we should charge half for deletion, but I will concede that it's prudent to apply a more restrictive absolute quality final test. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
