On Mon, Nov 24, 2014 at 10:49:45AM -0300, Alvaro Herrera wrote: > What's the general opinion on having test programs somewhere other than > contrib/ ?
General opinion: slightly favorable. > We currently have a number of subdirectories for test-only programs: > > test_parser (a toy text search parser, added in 2007) > dummy_seclabel (for SECURITY LABEL regression testing, added Sept 2010) > worker_spi (for bgworkers, added Dec 2012) > test_shm_mq (test program for shared memory queues, added Jan 2014) > test_decoding (test program for logical decoding, added March 2014) > What would you say if we were to move them to src/test/? I could also > see putting them in a brand new top-level directory, say testing/ or > testprg/. It's revealing that two of the first three responses each doubted the fit of one of those moves. I think that shows the lines aren't so bright after all, and this specific proposal is not strong enough. The line between a test module and a sample-code module is blurry. > Now, I know there is some resistance to the idea of moving source code > around. If this proposal is objected to, would people object the idea > of putting the commit timestamp test module in src/test/commit_ts > instead of the patch author's proposal, contrib/test_committs? I'd rather defend moving source code or defend continuing to dump in contrib than defend a src/test/modules defined as "test-oriented modules added after November 2014." Incidentally, +1 on "test_commit_ts" in preference to "test_committs". -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
