* Adam Brightwell (adam.brightw...@crunchydatasolutions.com) wrote: > > I don't see any changes to the regression test files, were they > > forgotten in the patch? I would think that at least the view definition > > changes would require updates to the regression tests, though perhaps > > nothing else. > > Hmmm... :-/ The regression tests that changed were in > 'src/test/regress/expected/rules.out' and should be near the bottom of the > patch.
Hah, looked just like changes to the system_views, sorry for the confusion. :) > > Overall, I'm pretty happy with the patch and would suggest moving on to > > writing up the documentation changes to go along with the code changes. > > I'll continue to play around with it but it all seems pretty clean to > > me and will allow us to easily add the additiaonl role attributes being > > discussed. > > Sounds good. I'll start on those changes next. Great! Thanks, Stephen
signature.asc
Description: Digital signature