> - Error to apply to the current master:

Works for me. 

$ git apply ~/pgbench-f-noexit-v2.patch 
$

Maybe git version difference or the patch file was malformed by mail
client?

> +static void executeStatement2(PGconn *con, const char *sql, const char
> *table);
> 
> I think we can use a better name like "executeStatementIfTableExists".

Point taken.

> +    if (result == NULL)
> +    {
> +        PQclear(res);
> +        return false;
> +    }
> +
> +    if (*result == 't')
> +    {
> +        PQclear(res);
> +        return false;    /* table does not exist */
> +    }
> 
> To simplify isn't better this way?
> 
> if (result == NULL || *result == 't')
> {
>     PQclear(res);
>     return false; /* table does not exists */
> }

Thanks for pointing it out.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to