On Mon, Dec 22, 2014 at 11:48:52PM +0100, Christoph Berg wrote: > Hi, > > I've played with trying to find out which minimal set of files I need > from the old version to make pg_upgrade work. Interestingly, this > includes the good old postmaster binary: > > $ sudo -u postgres pgsql/bin/pg_upgrade -b /var/tmp/pgsql/bin/ -B > /usr/lib/postgresql/9.5/bin/ -d /etc/postgresql/9.5/main -D /tmp/9.5/data > Finding the real data directory for the old cluster sh: 1: > /var/tmp/pgsql/bin/postmaster: not found > > Could not get data directory using "/var/tmp/pgsql/bin/postmaster" -D > "/etc/postgresql/9.5/main" -C data_directory: No such file or directory > Failure, exiting > > I think it should just use "postgres" there, patch attached. (If we > need to be compatible with postmaster-only PG versions from the last > century, it should try both names.)
Yes, I think you are right. I see pg_ctl using the 'postgres' binary, so pg_upgrade should do the same. I will apply this patch soon, and see if there are any other 'postmaster' mentions that need updating. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
