On Wed, Dec 24, 2014 at 9:42 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > Hi all, > > Commit 2c03216d has introduced RestoreBlockImage to restore a page > from a given decoding state. ISTM that this is a backend-only > operation but it has been added in xlogreader.c which could be used as > well by frontend utilities like pg_xlogdump. > Wouldn't it be better to declare it as a static routine in > xlogutils.c? If we keep it in xlogreader.c, I think that we should at > least wrap it with ifndef FRONTEND. > Thoughts?
If we do this, pg_lzcompress.c doesn't need to be moved to common for FPW compression patch which we're talking about in other thread. Right? DecodeXLogRecord() seems also a backend-only, so we should treat it in the same way as you proposed? Or pg_rewind uses that? Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers