On Fri, Dec 26, 2014 at 11:52:41PM +0530, Abhijit Menon-Sen wrote: > At 2014-12-26 13:11:43 -0500, br...@momjian.us wrote: > > > > Is this something that could potentially change the data stored on > > disk? Does pg_upgrade need to check for changes in this area? Is the > > detection exposed by pg_controldata? Could this affect running the > > data directory on a different CPU? > > No to all. > > Subsequent to Heikki's change (already in master) to use the CRC-32C > algorithm (instead of the earlier mistakenly-reflected-but-not-quite > one), both the slice-by-8 software implementation posted earlier and > the SSE4.2 CRC32* instructions will compute exactly the same value. > > (Yes, I have verified this in both cases.)
Uh, we didn't fully change all code to use the new algorithm because there were cases that the CRC was already stored on disk, e.g hstore, ltree. I assume you are only linking into Heikki's new code and will not change the places that use the old CRC method on disk --- just checking. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
