Here are some more tests for event triggers, especially about new features
introduced recently in 296f3a6053844089bc533630fffafaba8f016384.
Check that COMMENT, GRANT and REVOKE do trigger some events.
The patch also check some more error cases: SQL function, functions with
declared arguments, arguments passed to the trigger, event trigger on
global objects (ROLE, TABLESPACE, DATABASE).
I have left out "SECURITY LABEL" which would require a special security
label provider. Note that they do not seem to be tested at all anyway:-(
The "security_label.sql" really tests that all fails when no plugin is
available. If some actual tests are added to security label some day, I
think that event triggers about them should be tested there.
--
Fabien.
diff --git a/src/test/regress/expected/event_trigger.out b/src/test/regress/expected/event_trigger.out
index 2095794..2690c49 100644
--- a/src/test/regress/expected/event_trigger.out
+++ b/src/test/regress/expected/event_trigger.out
@@ -9,6 +9,15 @@ BEGIN
RAISE NOTICE 'test_event_trigger: % %', tg_event, tg_tag;
END
$$ language plpgsql;
+-- should fail, event triggers cannot have declared arguments
+create function test_event_trigger_arg(name text)
+returns event_trigger as $$ BEGIN RETURN 1; END $$ language plpgsql;
+ERROR: event trigger functions cannot have declared arguments
+CONTEXT: compilation of PL/pgSQL function "test_event_trigger_arg" near line 1
+-- should fail, SQL functions cannot be event triggers
+create function test_event_trigger_sql() returns event_trigger as $$
+SELECT 1 $$ language sql;
+ERROR: SQL functions cannot return type event_trigger
-- should fail, no elephant_bootstrap entry point
create event trigger regress_event_trigger on elephant_bootstrap
execute procedure test_event_trigger();
@@ -39,11 +48,32 @@ create event trigger regress_event_trigger2 on ddl_command_start
when tag in ('DROP EVENT TRIGGER')
execute procedure test_event_trigger();
ERROR: event triggers are not supported for DROP EVENT TRIGGER
+-- should fail, can't have event triggers on global objects
+create event trigger regress_event_trigger2 on ddl_command_start
+ when tag in ('CREATE ROLE')
+ execute procedure test_event_trigger();
+ERROR: event triggers are not supported for CREATE ROLE
+-- should fail, can't have event triggers on global objects
+create event trigger regress_event_trigger2 on ddl_command_start
+ when tag in ('CREATE DATABASE')
+ execute procedure test_event_trigger();
+ERROR: event triggers are not supported for CREATE DATABASE
+-- should fail, can't have event triggers on global objects
+create event trigger regress_event_trigger2 on ddl_command_start
+ when tag in ('CREATE TABLESPACE')
+ execute procedure test_event_trigger();
+ERROR: event triggers are not supported for CREATE TABLESPACE
-- should fail, can't have same filter variable twice
create event trigger regress_event_trigger2 on ddl_command_start
when tag in ('create table') and tag in ('CREATE FUNCTION')
execute procedure test_event_trigger();
ERROR: filter variable "tag" specified more than once
+-- should fail, can't have arguments
+create event trigger regress_event_trigger2 on ddl_command_start
+ execute procedure test_event_trigger('argument not allowed');
+ERROR: syntax error at or near "'argument not allowed'"
+LINE 2: execute procedure test_event_trigger('argument not allowe...
+ ^
-- OK
create event trigger regress_event_trigger2 on ddl_command_start
when tag in ('create table', 'CREATE FUNCTION')
@@ -72,6 +102,15 @@ create table event_trigger_fire1 (a int);
NOTICE: test_event_trigger: ddl_command_start CREATE TABLE
NOTICE: test_event_trigger: ddl_command_end CREATE TABLE
-- regress_event_trigger_end should fire here
+grant all on table event_trigger_fire1 to public;
+NOTICE: test_event_trigger: ddl_command_end GRANT
+-- regress_event_trigger_end should fire here
+comment on table event_trigger_fire1 is 'here is a comment';
+NOTICE: test_event_trigger: ddl_command_end COMMENT
+-- regress_event_trigger_end should fire here
+revoke all on table event_trigger_fire1 from public;
+NOTICE: test_event_trigger: ddl_command_end REVOKE
+-- regress_event_trigger_end should fire here
drop table event_trigger_fire1;
NOTICE: test_event_trigger: ddl_command_end DROP TABLE
-- alter owner to non-superuser should fail
diff --git a/src/test/regress/sql/event_trigger.sql b/src/test/regress/sql/event_trigger.sql
index c6e47ed..a584d33 100644
--- a/src/test/regress/sql/event_trigger.sql
+++ b/src/test/regress/sql/event_trigger.sql
@@ -10,6 +10,14 @@ BEGIN
END
$$ language plpgsql;
+-- should fail, event triggers cannot have declared arguments
+create function test_event_trigger_arg(name text)
+returns event_trigger as $$ BEGIN RETURN 1; END $$ language plpgsql;
+
+-- should fail, SQL functions cannot be event triggers
+create function test_event_trigger_sql() returns event_trigger as $$
+SELECT 1 $$ language sql;
+
-- should fail, no elephant_bootstrap entry point
create event trigger regress_event_trigger on elephant_bootstrap
execute procedure test_event_trigger();
@@ -42,11 +50,30 @@ create event trigger regress_event_trigger2 on ddl_command_start
when tag in ('DROP EVENT TRIGGER')
execute procedure test_event_trigger();
+-- should fail, can't have event triggers on global objects
+create event trigger regress_event_trigger2 on ddl_command_start
+ when tag in ('CREATE ROLE')
+ execute procedure test_event_trigger();
+
+-- should fail, can't have event triggers on global objects
+create event trigger regress_event_trigger2 on ddl_command_start
+ when tag in ('CREATE DATABASE')
+ execute procedure test_event_trigger();
+
+-- should fail, can't have event triggers on global objects
+create event trigger regress_event_trigger2 on ddl_command_start
+ when tag in ('CREATE TABLESPACE')
+ execute procedure test_event_trigger();
+
-- should fail, can't have same filter variable twice
create event trigger regress_event_trigger2 on ddl_command_start
when tag in ('create table') and tag in ('CREATE FUNCTION')
execute procedure test_event_trigger();
+-- should fail, can't have arguments
+create event trigger regress_event_trigger2 on ddl_command_start
+ execute procedure test_event_trigger('argument not allowed');
+
-- OK
create event trigger regress_event_trigger2 on ddl_command_start
when tag in ('create table', 'CREATE FUNCTION')
@@ -76,6 +103,15 @@ alter event trigger regress_event_trigger disable;
create table event_trigger_fire1 (a int);
-- regress_event_trigger_end should fire here
+grant all on table event_trigger_fire1 to public;
+
+-- regress_event_trigger_end should fire here
+comment on table event_trigger_fire1 is 'here is a comment';
+
+-- regress_event_trigger_end should fire here
+revoke all on table event_trigger_fire1 from public;
+
+-- regress_event_trigger_end should fire here
drop table event_trigger_fire1;
-- alter owner to non-superuser should fail
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
