On Fri, Feb 13, 2015 at 10:26 PM, Heikki Linnakangas <hlinnakan...@vmware.com> wrote: > In the "redesign checkpoint_segments" patch, Robert suggested keeping the > settings' base unit as "number of segments", but allow conversions from MB, > GB etc. I started looking into that and found that adding a new unit to > guc.c is quite messy. The conversions are done with complicated > if-switch-case constructs. > > Attached is a patch to refactor that, making the conversions table-driven. > This doesn't change functionality, it just makes the code nicer.
Isn't it good idea to allow even wal_keep_segments to converse from MB, GB etc? Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
