On Sat, Feb 28, 2015 at 12:29 AM, Gilles Darold <gilles.dar...@dalibo.com> wrote: > Le 26/02/2015 12:41, Michael Paquier a écrit : >> On Wed, Feb 25, 2015 at 7:46 AM, Gilles Darold <gilles.dar...@dalibo.com> >> wrote: >>> This is a far better patch and the test to export/import of the >>> postgis_topology extension works great for me. >>> >>> Thanks for the work. >> Attached is a patch that uses an even better approach by querying only >> once all the FK dependencies of tables in extensions whose data is >> registered as dumpable by getExtensionMembership(). Could you check >> that it works correctly? My test case passes but an extra check would >> be a good nice. The patch footprint is pretty low so we may be able to >> backport this patch easily. > > Works great too. I'm agree that this patch should be backported but I > think we need to warn admins in the release note that their > import/restore scripts may be broken.
Of course it makes sense to mention that in the release notes, this behavior of pg_dump being broken since the creation of extensions. Since it is working on your side as well, let's put it in the hands of a committer then and I am marking it as such on the CF app. The test case I sent on this thread can be used to reproduce the problem easily with TAP tests... -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers