On Tue, Mar 3, 2015 at 8:51 AM, Josh Berkus <j...@agliodbs.com> wrote:
> On 03/02/2015 03:43 PM, Andres Freund wrote:
>> Hi,
>>
>> On 2015-03-02 15:40:27 -0800, Josh Berkus wrote:
>>> ! #max_wal_size = 1GB # in logfile segments
>>
>> Independent of the rest of the changes, the "in logfile segments" bit
>> should probably be changed.
>
> Point! Although I think it's fair to point out that that wasn't my
> omission, but Heikki's.
>
> Version C, with that correction, attached.
Minor comments:
"The default settings are 5 minutes and 128 MB, respectively." in wal.sgml
needs to be updated.
int max_wal_size = 8; /* 128 MB */
It's better to update the above code in xlog.c. That's not essential, though.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
