Dear hackers, I would like to ask you if is there any reason to pretend tcl scripts are shell scripts?
I am speaking namely about these files http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob_plain;f=src/pl/tcl/modules/pltcl_delmod.in;hb=HEAD http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob_plain;f=src/pl/tcl/modules/pltcl_listmod.in;hb=HEAD http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob_plain;f=src/pl/tcl/modules/pltcl_loadmod.in;hb=HEAD Here is the part of code I am speaking about: #! /bin/sh # Start tclsh \ exec @TCLSH@ "$0" "$@" instead of #! /usr/bin/tclsh or #! @TCLSH@ I am asking because our test suite is triggering errors on this [1]. In this case, it seems easier to modify code rather then test suite. Please apply attached patch if there is no particular reason for use of /bin/sh. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1199464 -- Jozef Mlich <jml...@redhat.com> Associate Software Engineer - EMEA ENG Developer Experience Mobile: +420 604 217 719 http://cz.redhat.com/ Red Hat, Inc.
diff --git a/src/pl/tcl/modules/pltcl_delmod.in b/src/pl/tcl/modules/pltcl_delmod.in index daa4fac..6b8cda4 100644 --- a/src/pl/tcl/modules/pltcl_delmod.in +++ b/src/pl/tcl/modules/pltcl_delmod.in @@ -1,8 +1,6 @@ -#! /bin/sh +#! @TCLSH@ # src/pl/tcl/modules/pltcl_delmod.in # -# Start tclsh \ -exec @TCLSH@ "$0" "$@" # # Code still has to be documented diff --git a/src/pl/tcl/modules/pltcl_listmod.in b/src/pl/tcl/modules/pltcl_listmod.in index 7d930ff..c3ea138 100644 --- a/src/pl/tcl/modules/pltcl_listmod.in +++ b/src/pl/tcl/modules/pltcl_listmod.in @@ -1,8 +1,6 @@ -#! /bin/sh +#! @TCLSH@ # src/pl/tcl/modules/pltcl_listmod.in # -# Start tclsh \ -exec @TCLSH@ "$0" "$@" # # Code still has to be documented diff --git a/src/pl/tcl/modules/pltcl_loadmod.in b/src/pl/tcl/modules/pltcl_loadmod.in index 645c6bb..06b459b 100644 --- a/src/pl/tcl/modules/pltcl_loadmod.in +++ b/src/pl/tcl/modules/pltcl_loadmod.in @@ -1,6 +1,5 @@ -#! /bin/sh -# Start tclsh \ -exec @TCLSH@ "$0" "$@" +#! @TCLSH@ +# # # Code still has to be documented
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
