On Sat, Feb 14, 2015 at 4:19 PM, Kevin Grittner <kgri...@ymail.com> wrote: > At some point we could consider building on this patch to recheck > index conditions for heap access when a non-MVCC snapshot is used, > check the visibility map for referenced heap pages when the TIDs > are read for an index-only scan, and/or skip LP_DEAD hinting for > non-WAL-logged indexes. But all those are speculative future work; > this is a conservative implementation that just didn't modify > pinning where there were any confounding factors.
I don't have the bandwidth for a full review, but I took a quick look at this. I think you should call out those "confounding factors" in the README. It's not hard to piece them together from _bt_drop_lock_and_maybe_pin(), but I think you should anyway. Don't use BUFFER_LOCK_SHARE -- use BT_READ, as the existing nbtree LockBuffer() callers do. You're inconsistent about that in V3. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
